clang-tidy: range for loop conversions #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
force-pushed
the
def
branch
7 times, most recently
from
6902719
to
1eefca2
Compare
neheb
commented
Apr 29, 2021
hassec
requested changes
Apr 29, 2021
neheb
force-pushed
the
def
branch
8 times, most recently
from
bce1a4e
to
28e9395
Compare
piponazo
previously approved these changes
May 3, 2021
Found with modernize-loop-convert Ran through git clang-format. Also removed several questionable loops and replaced with simpler algorithms. Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
Rebased. |
piponazo
approved these changes
May 3, 2021
nehaljwani
added a commit
to nehaljwani/exiv2
that referenced
this pull request
Jan 18, 2023
This is a partial backport of Exiv2#1596 This serves as a work around for a weird bug in Apple Clang 14.0.* xref: https://stackoverflow.com/q/75153729/1005215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found with modernize-loop-convert
Ran through git clang-format.
Also removed several questionable loops and replaced with simpler
algorithms.
Signed-off-by: Rosen Penev rosenp@gmail.com