clang-tidy: use = delete #1593
Merged
clang-tidy: use = delete #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found with modernize-use-equals-delete Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
I'll try to look at it in the next days. Sorry for the slow response but I this week is being crazy for me 😇 |
|
The code also looks good to me. The CI issues seem to be intermittent networking problems ... I just retriggered the jobs that were failing. However, the travis-ci Valgrind job is constantly failing. Probably Travis have changed again something in their docker images 👿 . That issue will not block the merging of this PR. I will take care of that in other branch. |
piponazo
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found with modernize-use-equals-delete
Signed-off-by: Rosen Penev rosenp@gmail.com