Clean wdeprecated-copy warnings and others #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done so that when we use EXIV2_TEAM_EXTRA_WARNINGS we do not get warnings about XMPSDK (we do not want to deal with those)
Most of the warnings fixed were: - Hiding of local variables - Hiding of globals - Useless casts - Conversions between float/double
|
This pull request introduces 1 alert and fixes 3 when merging a19f5cc into 04c4c84 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 3 when merging ab2c997 into 04c4c84 - view on LGTM.com new alerts:
fixed alerts:
|
clanmills
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main objective of this PR was to clean the warnings reported by
-Wdeprecated-copywhich were not treated as errors temporarily after enabling C++11 onmain.This PR cleans all these warnings and others reported when using the option
EXIV2_TEAM_EXTRA_WARNINGSon CMake. The compiler output should be much cleaner now.