Ugly compiler warning on MinGW/msys2 from src/localhost.c

[clanmills]

514 MSYS64:rmills@rmillsmbp-w7:~/gnu/github/exiv2/exiv2/build $ make
[ 18%] Built target xmp
Scanning dependencies of target exiv2lib_int
[ 20%] Building C object src/CMakeFiles/exiv2lib_int.dir/localtime.c.o
/c/msys64/home/rmills/gnu/github/exiv2/exiv2/src/localtime.c: In function 'tzload':
/c/msys64/home/rmills/gnu/github/exiv2/exiv2/src/localtime.c:268:19: warning: implicit declaration of function 'access' [-Wimplicit-function-declaration]
   if (doaccess && access(name, R_OK) != 0)
                   ^~~~~~
/c/msys64/home/rmills/gnu/github/exiv2/exiv2/src/localtime.c:282:7: warning: implicit declaration of function 'read'; did you mean 'fread'? [-Wimplicit-function-declaration]
   i = read(fid, u.buf, sizeof u.buf);
       ^~~~
       fread
/c/msys64/home/rmills/gnu/github/exiv2/exiv2/src/localtime.c:283:7: warning: implicit declaration of function 'close'; did you mean 'pclose'? [-Wimplicit-function-declaration]
   if (close(fid) != 0)
       ^~~~~
       pclose
[ 45%] Built target exiv2lib_int
[ 46%] Linking CXX shared library ../bin/msys-exiv2-27.dll
make[2]: *** Deleting file 'bin/msys-exiv2-27.dll'
make[2]: *** [src/CMakeFiles/exiv2lib.dir/build.make:1240: bin/msys-exiv2-27.dll] Interrupt
make[1]: *** [CMakeFiles/Makefile2:178: src/CMakeFiles/exiv2lib.dir/all] Interrupt
make: *** [Makefile:130: all] Interrupt

515 MSYS64:rmills@rmillsmbp-w7:~/gnu/github/exiv2/exiv2/build $

Fix is easy:

512 MSYS64:rmills@rmillsmbp-w7:~/gnu/github/exiv2/exiv2/build $ git diff
diff --git a/src/localtime.c b/src/localtime.c
index 3ec0925c..55ad84ff 100644
--- a/src/localtime.c
+++ b/src/localtime.c
@@ -5,6 +5,9 @@

 #include "config.h"
 #include "timegm.h"
+#ifdef   EXV_HAVE_UNISTD_H
+#include "unistd.h"
+#endif

 /*
 ** This file is in the public domain, so clarified as of
513 MSYS64:rmills@rmillsmbp-w7:~/gnu/github/exiv2/exiv2/build $

[piponazo]

Since this is fixed in #557 (which will be merged tomorrow), I'll close this issue.