[EXILED::Events] Fix downloading NWAPI plugins with hub install

[bladuk]

Description

Describe the changes
This PR fixes the NWAPI plugin installation with the hub install command.

What is the current behavior? (You can also link to an open issue here)
hub install fetches every single asset in the plugin release and downloads it.

What is the new behavior? (if this is a feature change)
hub install will now filter assets with the -NWAPI postfix in the name.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Other information:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentations

Submission checklist

• I have checked the project can be compiled
• I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

• I have checked no IL patching errors in the console

Other

• Still requires more testing

[bladuk]

Build actions has been failed due to GH Actions outage and should be restarted.

[iamalexrouse]

While I'm not too happy about the hub install command residing within the events library, I'm not too fussed.

The issue I have with this PR is the requirement for a standardized naming scheme which considering the large amount of new developers entering the EXILED plugin development scene, would be difficult to communicate easily especially when newer developers may have been used to a completely different naming schemes or none at all.

If the naming conventions will be applied web-side, I'm not too opposed to adding this change. Though I have some nitpicks which you can see below.

Secondly, with plugin downloads, is there any plans to add a validation stage for ensuring plugins install without corruption? Validation is usually used or detecting problems like a bad download which, may help avoid having corrupted plugins from potentially causing issues after install.

Thanks,
Alex

[bladuk]

@iamalexrouse, Hello

Of course, this is a temporary hotfix to a big problem. The naming “SomePlugin-NWAPI.dll” isn't really a standard, but has been widely used by many developers since the NWAPI release. We are currently working on a more accurate and user-friendly solution to this issue.

Regarding the integrity check for the downloaded files, it's currently not planned but we'll think about your suggestion.

Thanks for the feedback anyway!