RabbitMQ improvements #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielpastori1
approved these changes
Mar 4, 2024
|
Excellent contribution, I have some points, there is a console.log in the middle of the code if you can remove it, it is cleaner, does the old configuration remain functional if I don't configure the envs? we need to avoid break changes as much as possible |
|
@DavidsonGomes logs removed and code adapted to be compatible with current working services event without informing the env variables |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we improved the RabbitMQ feature, by adding 3 modes to it:
isolated
In this mode each instance will have an exchange and linked to a queue defined by the name of the events, the exchanges will be binded to them:
The exchange name will be the instance name
Screenshots
  single
In this mode we'll have one exchange and one queue.
The exchange name can be customized from the env file
The queue name will be
evolutionScreenshots
 global
IMO this is the best option In this mode will have one exchange and 5 queues, each queue will be grouped by a few events, you can check on the screenshots bellow:
The exchange name can be customized from the env file
Screenshots
  2 new parameters has been added to env file:
RABBITMQ_RABBITMQ_MODE=global-> acceps single/global/isolatedRABBITMQ_EXCHANGE_NAME=evolution_exchange-> will only be used in global/single