Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump versions #1832

Merged
merged 1 commit into from
Mar 23, 2021
Merged

build(deps): bump versions #1832

merged 1 commit into from
Mar 23, 2021

Conversation

driskull
Copy link
Member

build(deps): bump versions

@driskull driskull added the 1 - assigned Issues that are assigned to a sprint and a team member. label Mar 23, 2021
@driskull driskull self-assigned this Mar 23, 2021
@driskull driskull requested a review from a team as a code owner March 23, 2021 16:10
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🎉

@paulcpederson
Copy link
Member

@eriklharper will this fix #1121 ?

@driskull driskull merged commit b8f12cb into master Mar 23, 2021
@driskull driskull deleted the dris0000/bump branch March 23, 2021 16:28
@eriklharper
Copy link
Contributor

@eriklharper will this fix #1121 ?

Doubt it. Ionic still has not addressed this underlying bug with relocating default slotted content in scoped components: ionic-team/stencil#2801.

Based on recent discussions I've been having about labelling form components, I think we should deprecate built-in label support in calcite-radio-button (and any other component that is currently doing this like calcite-checkbox) and have users supply their own label instead. Because both calcite-radio-button and calcite-label components are scoped and use default <slot />s, this issue could still persist inside calcite-label even after the built-in labelling support is removed from said components, but this would simplify them and remove the need for a fix on Ionic's end.

As far as how to handle the Stencil bug that is still affecting calcite-label, a possible solution would be to turn calcite-label back into a shadowed component, but then require the user to pass their own <label> tag into the default slot so that calcite-label can style it and keep the label available for form and accessibility on the document.

The crux of this Stencil bug is that it is difficult to replicate slot functionality for non-shadow DOM components because manual dom manipulation is required, which interferes with VDOM tools, which are designed to strictly control the DOM structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants