Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for nevergrad tests #913

Merged
merged 2 commits into from
May 13, 2022
Merged

Hotfix for nevergrad tests #913

merged 2 commits into from
May 13, 2022

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented May 13, 2022

  • Missing from __future__ import annotations at the top of integration_test.py
  • Remove the Generic base for the test class, which prevented tests from being collected in python 3.7

@lebrice
Hotfix for nevergrad tests
ce52e1c 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove uses of BaseAlgoTests as a Generic class
b1d765c 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
bouthilx
bouthilx approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lebrice lebrice merged commit 2a17b70 into develop May 13, 2022
@lebrice lebrice deleted the hotfix_nevergrad_tests branch May 13, 2022 19:55
@wagnersj wagnersj mentioned this pull request May 17, 2022
Merged
6 tasks
@bouthilx bouthilx added the ci label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lebrice @bouthilx