Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_prior_string [#774] #776

Merged
merged 12 commits into from
Feb 4, 2022
Merged

Fix get_prior_string [#774] #776

merged 12 commits into from
Feb 4, 2022

Conversation

Delaunay
Copy link
Collaborator

@Delaunay Delaunay commented Feb 1, 2022

Hi there! Thank you for contributing. Feel free to use this pull request template; It helps us reviewing your work at its true value.

Please remove the instructions in italics before posting the pull request :).

Description

Describe what is the purpose of this pull request and why it should be integrated to the repository.
When your changes modify the current behavior, explain why your solution is better.

If it solves a GitHub issue, be sure to link it.

Changes

Give an overview of the suggested solution.

Checklist

This is simply a reminder of what we are going to look for before merging your code.

Add an x in the boxes that apply.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
You can also fill these out after creating the PR if it's a work in progress (be sure to publish the PR as a draft then)

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

Further comments

Please include any additional information or comment that you feel will be helpful to the review of this pull request.

@Delaunay Delaunay changed the title Stuff Fix get_prior_string #774 Feb 1, 2022
@Delaunay Delaunay changed the title Fix get_prior_string #774 Fix get_prior_string [#774] Feb 1, 2022
@Delaunay
Copy link
Collaborator Author

Delaunay commented Feb 1, 2022

#774

@bouthilx
Copy link
Member

bouthilx commented Feb 4, 2022

Conda issue fixed in #780

Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Delaunay Delaunay merged commit 5bd0a37 into Epistimio:develop Feb 4, 2022
@Delaunay Delaunay deleted the fix-774 branch February 4, 2022 16:44
@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Feb 8, 2022
@bouthilx bouthilx mentioned this pull request Feb 11, 2022
lebrice pushed a commit to lebrice/orion that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants