Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASHA for identical objectives #699

Merged

Conversation

bouthilx
Copy link
Member

Why:

The sorting of trials during promotion was not only looking at
objectives, but also at trials. Problem is, trials are not comparable.
This bug was not detected because during tests trials always have a
different objective, hence the comparisons would always stop at the
objective when comparing the tuples (objective, trial).

How:

Add tests with identical objectives, and use objective only for sorting.

Why:

The sorting of trials during promotion was not only looking at
objectives, but also at trials. Problem is, trials are not comparable.
This bug was not detected because during tests trials always have a
different objective, hence the comparisons would always stop at the
objective when comparing the tuples (objective, trial).

How:

Add tests with identical objectives, and use objective only for sorting.
@bouthilx bouthilx added the bug Indicates an unexpected problem or unintended behavior label Nov 25, 2021
@bouthilx bouthilx added this to the v0.2.1 milestone Nov 25, 2021
@bouthilx bouthilx merged commit ed9a57a into Epistimio:develop Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant