Handle extra API attributes with a warning.

[caius]

Rather than die with a NoMethodError, just #warn about trying to set a non-existent attribute instead.

[EmmanuelOga]

Hi there. Not sure why are you doing that. Where are those extra API parameters coming from? Are you trying to add your own attributes to the objects, or are you getting extra parameters from campfire (i.e., is any of the firering classes outdated?)

[caius]

They've added an extra attribute to the user json (avatar_url), which currently causes firering to crash out with a NoMethodError for avatar_url=. Idea of this commit is to stop firering crashing in the time between new attributes being added and firering being updated. Coding defensively when something that will change beyond your control is a good thing in my opinion.

[wjessop]

EmmanuelOga, check out the API docs http://developer.37signals.com/campfire/users.

https://github.com/EmmanuelOga/firering/blob/master/lib/firering/instantiator.rb#L12-15 is broken because it makes assumptions about the format of the data we return, and we added a field.

[EmmanuelOga]

Being defensive is important, as it is being correct. That's why I was asking what was the underlying cause of you wanting to add that code. Looks good to me, I'll add it and change a little bit the wording. I'll change it too to use the built in logger.

[EmmanuelOga]

btw, just released this together with the avatar_url fix as 1.1.0.