Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codegen backend dylib back into depinfo (.d) post-rust-lang/rust#93969. #927

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Oct 14, 2022

This unbreaks the ability of Cargo to know to rebuild shader dependencies when rustc_codegen_spirv changes - after this PR, attempting to e.g. run one of the example runners, or cargo compiletest, after making a change in rustc_codegen_spirv, will cause all SPIR-V target dependencies (core, spirv-std etc.) to be rebuilt.

We apparently used to be enjoying this by default until:

And never got around to updating to set the opt-in flag (sorry, @bjorn3!).

@eddyb eddyb requested a review from oisyn as a code owner October 14, 2022 13:30
@eddyb eddyb enabled auto-merge (rebase) October 14, 2022 13:34
@eddyb eddyb merged commit 4b10bf5 into EmbarkStudios:main Oct 14, 2022
@eddyb eddyb deleted the bindep branch October 14, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants