New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: size estimation for pegin transactions #1355

Merged

delta1 merged 1 commit into ElementsProject:master from delta1:pegin-estimate

Aug 16, 2024

Member

delta1 commented Aug 14, 2024

Fixes the size estimation for pegin transactions, the witness scale factor was only being applied to the pubkey and not the rest of the witness data.

The overestimation is ~56 bytes

>>> (1+1+72+1+33/4)
83.25
>>> (1+1+72+1+33)/4
27.0
>>> 83.25 - 27.0
56.25


          fix: size estimation for pegin transactions

c1bc7ca

apoelstra approved these changes

View reviewed changes

Member

apoelstra left a comment

utACK c1bc7ca

delta1 merged commit e40b57d into ElementsProject:master

9 of 13 checks passed

delta1 deleted the pegin-estimate branch

August 16, 2024 12:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet