Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zh-CN): Add new words and phrases, add voice to generator script #46

Merged
merged 5 commits into from
Sep 19, 2022

Conversation

zyren
Copy link
Contributor

@zyren zyren commented Sep 19, 2022

All voice files have been made as listed in the new CSV file.

All voice files have been made as listed in the new CSV file
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, thank you! :)

The three renamed files have filenames that are too long (plus they don't match the names in the csv) - non-system files have a limit of 6 character filenames (minus extension).

pfeerick@DESKTOP-RSREF72:~/repos/edgetx-sdcard-sounds$ ./build-checks.sh 
File name length checks...
Filename is too long: SOUNDS/cn/landing.wav
Filename is too long: SOUNDS/cn/pattern.wav
Filename is too long: SOUNDS/cn/takeoff.wav

Can you also update the zh-CN entry in https://github.com/EdgeTX/edgetx-sdcard-sounds/blob/main/generate.sh so it can be used in the future for generating sounds ... it's mainly just missing the voice name

@zyren
Copy link
Contributor Author

zyren commented Sep 19, 2022

Firstly, thank you! :)

The three renamed files have filenames that are too long (plus they don't match the names in the csv) - non-system files have a limit of 6 character filenames (minus extension).

pfeerick@DESKTOP-RSREF72:~/repos/edgetx-sdcard-sounds$ ./build-checks.sh 
File name length checks...
Filename is too long: SOUNDS/cn/landing.wav
Filename is too long: SOUNDS/cn/pattern.wav
Filename is too long: SOUNDS/cn/takeoff.wav

Can you also update the zh-CN entry in https://github.com/EdgeTX/edgetx-sdcard-sounds/blob/main/generate.sh so it can be used in the future for generating sounds ... it's mainly just missing the voice name

Oh no problem, I'll fix it right away.

@zyren zyren closed this Sep 19, 2022
@zyren zyren reopened this Sep 19, 2022
@zyren zyren requested a review from pfeerick September 19, 2022 06:20
@pfeerick
Copy link
Member

So which of the zn-CN voices are you using to generate that audio?

i.e. either one of the voices listed against zh-CN here https://learn.microsoft.com/en-us/azure/cognitive-services/speech-service/language-support?tabs=stt-tts#prebuilt-neural-voices

or can be demoed here https://azure.microsoft.com/en-us/products/cognitive-services/text-to-speech/#features

@zyren
Copy link
Contributor Author

zyren commented Sep 19, 2022

Sorry I didn't figure it out before, now I know what to do.

@pfeerick
Copy link
Member

Thank you! :) Just means it's ready to go now if more need to be added, or I need to regenerate from scratch.

@pfeerick pfeerick changed the title Improve Chinese voices feat(zh-CN): Add new words and phrases, add voice to generator script Sep 19, 2022
@zyren
Copy link
Contributor Author

zyren commented Sep 19, 2022

Thank you! :) Just means it's ready to go now if more need to be added, or I need to regenerate from scratch.

Yes, the audio files I uploaded were made with other TTS tools, I just found out today that Microsoft's TTS is more natural and sounding better, please regenerate if possible.

@pfeerick
Copy link
Member

Sure, can do that. :) I'll merge this as is, and regenerate the zh-CN pack tomorrow.

@pfeerick pfeerick merged commit ca65372 into EdgeTX:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants