-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zh-CN): Add new words and phrases, add voice to generator script #46
Conversation
All voice files have been made as listed in the new CSV file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly, thank you! :)
The three renamed files have filenames that are too long (plus they don't match the names in the csv) - non-system files have a limit of 6 character filenames (minus extension).
pfeerick@DESKTOP-RSREF72:~/repos/edgetx-sdcard-sounds$ ./build-checks.sh
File name length checks...
Filename is too long: SOUNDS/cn/landing.wav
Filename is too long: SOUNDS/cn/pattern.wav
Filename is too long: SOUNDS/cn/takeoff.wav
Can you also update the zh-CN entry in https://github.com/EdgeTX/edgetx-sdcard-sounds/blob/main/generate.sh so it can be used in the future for generating sounds ... it's mainly just missing the voice name
Oh no problem, I'll fix it right away. |
So which of the zn-CN voices are you using to generate that audio? i.e. either one of the voices listed against or can be demoed here https://azure.microsoft.com/en-us/products/cognitive-services/text-to-speech/#features |
Sorry I didn't figure it out before, now I know what to do. |
Thank you! :) Just means it's ready to go now if more need to be added, or I need to regenerate from scratch. |
Yes, the audio files I uploaded were made with other TTS tools, I just found out today that Microsoft's TTS is more natural and sounding better, please regenerate if possible. |
Sure, can do that. :) I'll merge this as is, and regenerate the zh-CN pack tomorrow. |
All voice files have been made as listed in the new CSV file.