Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add misc phases #124

Merged
merged 6 commits into from
Aug 4, 2024
Merged

feat: add misc phases #124

merged 6 commits into from
Aug 4, 2024

Conversation

pfeerick
Copy link
Member

@pfeerick pfeerick commented Aug 2, 2024

cf. #118, #123

@pfeerick pfeerick merged commit 375fb03 into main Aug 4, 2024
1 check passed
@pfeerick pfeerick deleted the pfeerick/add-phases branch August 4, 2024 04:35
@inventor7777
Copy link

@pfeerick

The “BEC Overload” file sounds like BC Overload, the way Ryan (and I would assume other voices) says it. Perhaps it could be changed to “Receiver Overload” so it’s more clear on the radio.

@pfeerick
Copy link
Member Author

pfeerick commented Aug 5, 2024

Some say it that way, some sound clearer... I think like 2 out of all the en voices say the "e" really fast or skip it, and when I tried to stretch it all the others started saying b E E c 😂

BEC is different to receiver (plus a receiver is unlikely to overload) so what is the goal/use case here? Maybe there is another phrase that would suit.

@inventor7777
Copy link

In this case, it’s to alert the user when a servo gets jammed (which would lower the BEC voltage) so that servo overheating and damage can be avoided.

Maybe you could use a source word such as “beck” to make it say it more as a word, instead of B E C. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add surface drive mode sounds (EN) Couple new phrases and QOL words
2 participants