-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preview-web can't be run on forks #84
Open
pfeerick
wants to merge
17
commits into
EdgeTX:main
Choose a base branch
from
pfeerick:preview-web-no-secrets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+446
−415
Commits on Jun 13, 2024
-
fix: preview-web can't be run on forks
GitHub repo SECRETS are not exposed to forks, thus the preview-web step can't be run on pull requests from forks.
Configuration menu - View commit details
-
Copy full SHA for 9ccddc8 - Browse repository at this point
Copy the full SHA 9ccddc8View commit details
Commits on Jun 20, 2024
-
chore: first attempt at permission dependent building
From what I can see, it appears to be linked to the checkout, so may need to be done for both compile and storyboard steps as they are dependencies of preview-web.
Configuration menu - View commit details
-
Copy full SHA for d9856b0 - Browse repository at this point
Copy the full SHA d9856b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bdcf8f - Browse repository at this point
Copy the full SHA 7bdcf8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1256fe6 - Browse repository at this point
Copy the full SHA 1256fe6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ee6d75 - Browse repository at this point
Copy the full SHA 6ee6d75View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcf9ba6 - Browse repository at this point
Copy the full SHA fcf9ba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 087bab8 - Browse repository at this point
Copy the full SHA 087bab8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f04f81 - Browse repository at this point
Copy the full SHA 2f04f81View commit details -
Configuration menu - View commit details
-
Copy full SHA for c333684 - Browse repository at this point
Copy the full SHA c333684View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2676c68 - Browse repository at this point
Copy the full SHA 2676c68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 150b9f7 - Browse repository at this point
Copy the full SHA 150b9f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e5bcfd - Browse repository at this point
Copy the full SHA 9e5bcfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3c0912 - Browse repository at this point
Copy the full SHA c3c0912View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf8d5e6 - Browse repository at this point
Copy the full SHA cf8d5e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f0eac7 - Browse repository at this point
Copy the full SHA 4f0eac7View commit details
Commits on Jul 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5f1e295 - Browse repository at this point
Copy the full SHA 5f1e295View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37c1dbb - Browse repository at this point
Copy the full SHA 37c1dbbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.