Log HTTP 409 error responses with breadcrumbs #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
Aug 30, 2024
src/core/account/account-init.ts
Outdated
| @@ -37,6 +37,9 @@ async function createChildLogin( | |||
| login: LoginTree, | |||
| appId: string | |||
| ): Promise<LoginTree> { | |||
| // For crash errors: | |||
| ai.props.log.breadcrumb('createChildLogin', {}) | |||
There was a problem hiding this comment.
Move this to ensureAccountExists as part of the logic.
There was a problem hiding this comment.
There already is a log to ensureAccountExists. But it doesn't necessarily catch whether createChildLogin was invoked.
Comment on lines
+67
to
+68
| // For crash errors: | ||
| ai.props.log.breadcrumb('makeKeysKit', {}) |
There was a problem hiding this comment.
This seems redundant with all the other logging, but I guess we could keep it to have a trace like:
- createCurrencyWallet
- makeKeysKit (no kidding?)
- crash: Login API conflict error
There was a problem hiding this comment.
I'm erring on the side of redundancy since this could be a race-condition issue somewhere, so having more information even if it's obvious could reveal to us the race condition.
swansontec
approved these changes
Sep 2, 2024
The breadcrumbs were left in places leading up to `/v2/login/create` and `/v2/login/keys` endpoints to the login server.
samholmes
force-pushed
the
sam/409-formula
branch
from
68850dc
to
8a70300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breadcrumbs were left in places leading up to
/v2/login/createand/v2/login/keysendpoints to the login server.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none