Fix saving tokens at wallet creation time #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a race condition between loading the tokens file off disk and writing the tokens file at wallet creation time. We solve the race condition by skipping the `dispatch` if there is no file on disk. That way, when we create a brand-new wallet, the initial tokens always win the race.
swansontec
force-pushed
the
william/fix-wallet-token-creation
branch
from
f6c5709
to
eae1fbc
Compare
peachbits
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a race condition between loading the tokens file off disk and writing the tokens file at wallet creation time. We solve the race condition by skipping the
dispatchif there is no file on disk. That way, when we create a brand-new wallet, the initial tokens always win.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none