Support global nginx-proxy container #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
kirtangajjar
changed the title
Modify docker-compose mustache to support multiple network Remove external property on site-network block Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
kirtangajjar
changed the title
rahulsprajapati
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR of - EasyEngine/easyengine#1187
Adds a global network block in docker-compose and connects nginx server to it.
Earlier it used to be that there was a single network per site and nginx-proxy was connected to it.
Now there is a special
ee-global-networknetwork. All nginx containers of all sites will be connected to it and there will be seperate site-name network in which all containers of same site will connect.This PR also fixes an issue that I came up in testing in which site creation was not failing with proper error message when
wp core downloadfailed.Signed-off-by: Kirtan Gajjar kirtangajjar95@gmail.com