Add postfix container #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
|
Blocked due to EasyEngine/easyengine#1135. Will need to update this PR after EasyEngine/easyengine#1135 is merged. |
mbtamuli
suggested changes
Aug 1, 2018
src/Site_Command.php
Outdated
| mkdir( $site_conf_dir . '/postfix' ); | ||
| mkdir( $site_conf_dir . '/postfix/ssl' ); | ||
| $ssl_dir = $site_conf_dir . '/postfix/ssl'; | ||
| return \EE\Utils\default_launch("openssl req -new -x509 -nodes -days 365 -subj \"/CN=smtp.example.com\" -out $ssl_dir/server.crt -keyout $ssl_dir/server.key"); |
There was a problem hiding this comment.
Also, the CN should be $site_name
The key file has to have permission 600.
chmod 0600 /etc/ssl/postfix/server.key
Change permission of server.key to 0600 Correct image name Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
mbtamuli
approved these changes
Aug 2, 2018
|
@kirtangajjar Will you update this PR with the new structure of the site command or will you create a new PR? |
|
Closing it in favour of new PR opened post refactoring: EasyEngine/site-type-wp#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kirtan Gajjar kirtangajjar95@gmail.com