Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valis 8 prevent collision btw annot txts #4228

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Valis 8 prevent collision btw annot txts #4228

wants to merge 12 commits into from

Conversation

leepc12
Copy link
Contributor

@leepc12 leepc12 commented Jan 4, 2022

@leepc12 leepc12 requested review from emro and zoldello and removed request for emro January 5, 2022 20:04
@leepc12 leepc12 requested review from emro and removed request for zoldello January 13, 2022 00:16
emro
emro requested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@emro emro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except that we don't want the d3 library updates, just the Valis library update.

@leepc12 leepc12 requested a review from emro January 14, 2022 18:04
emro
emro previously approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@emro emro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@leepc12 leepc12 requested a review from emro January 28, 2022 17:33
emro
emro approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@emro emro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emro emro emro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leepc12 @emro