Lcms #11
Merged
Lcms #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lcms Yuri's updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Yuri,
Here is a function for finding the metal peaks in the LCICPMS data. It returns a dictionary with RT as keys and the metal as value. It's simple but functional.
I'm not sure all of the parameters in the existing peak picking algorithm are needed for the ICPMS data. Or maybe there is some way to better adapt it to the ICPMS data. It mostly gets the picks right, but not always. One thing that isn't clear to me is how or whether to subtract baseline, and whether the prominence and peak height parameters are important for the LCICPMS data.
Anyways, perhaps we can meet soon to discuss next steps.
-Christian