Add map() method to Triplestore #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 67.07% // Head: 67.04% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 67.07% 67.04% -0.04%
==========================================
Files 14 14
Lines 1063 1065 +2
==========================================
+ Hits 713 714 +1
- Misses 350 351 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
quaat
approved these changes
Jan 27, 2023
| @@ -495,6 +495,32 @@ def prefix_iri(self, iri: str, require_prefixed: bool = False): | |||
| raise NamespaceError(f"No prefix defined for IRI: {iri}") | |||
| return iri | |||
|
|
|||
| def map( | |||
There was a problem hiding this comment.
Why is there a method that just calls another method instead of just calling the other method directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of PR #67
Add a map() method to triplestore that is equivalent to
add_mapsTo(), except that it reverts the two first arguments and removes the thirdproperty_nameargument.The motivation for this method is that it has a more natural order of arguments.
The reason for the reverse argument order of
add_mapsTo()was to make mappings from data models easier by allowing to provide the data model as one argument and the property name as another. However, with the use of namespaces, it turned out that it was as easy to refer to properties using their full IRI.