Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out __hash__() and __eq__() methods from Literal. #55

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Dec 15, 2022

This fixes the issues in SINTEF/dlite#375

We still have to understand exactly why adding __hash__() and __eq__() creates an issue. It seems to change the datatype of some literals...

@codecov-commenter
Copy link

Codecov Report

Base: 74.05% // Head: 73.43% // Decreases project coverage by -0.62% ⚠️

Coverage data is based on head (4a29dc1) compared to base (653cfb7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   74.05%   73.43%   -0.63%     
==========================================
  Files          12       12              
  Lines         740      734       -6     
==========================================
- Hits          548      539       -9     
- Misses        192      195       +3     
Impacted Files Coverage Δ
tripper/literal.py 83.33% <ø> (-1.52%) ⬇️
tripper/namespace.py 89.15% <0.00%> (-3.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jesper-friis jesper-friis merged commit 3647ac1 into main Dec 16, 2022
@jesper-friis jesper-friis deleted the no-hashable-literal branch December 16, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants