Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up repository & fix workflows #5

Merged
merged 21 commits into from
Oct 12, 2022
Merged

Clean up repository & fix workflows #5

merged 21 commits into from
Oct 12, 2022

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Oct 7, 2022

Fixes #1
Fixes #2

This PR is an initial "clean up" of the files under tripper as well as a code base update according to the pre-commit hooks.
Furthermore, this ensures the CI workflows pass.


Fixes #8

The latest commits now enables releasing the package to PyPI under the name tripperpy, which should (hopefully) be updated to tripper once the issue pypi/support#2286 has been resolved.

Move files around, use imports from "tripper.*" and extend Python
support to include 3.7 and 3.8.
First run through with in-place changes from pre-commit hooks
Split up tests into separate test functions for better environment
isolation.
This should be considered temporary and should be fixed ASAP.
Added return types to `serialize()` method.
@CasperWA CasperWA marked this pull request as ready for review October 7, 2022 14:24
@CasperWA CasperWA requested a review from quaat October 7, 2022 14:24
Temporarily do not publish package on PyPI.
@CasperWA
Copy link
Contributor Author

CasperWA commented Oct 7, 2022

Issues #6, #7, and #8 have been opened to follow up on changes introduced by this PR and general information found in the code base.

docs/overview.md Outdated Show resolved Hide resolved
tripper/triplestore.py Outdated Show resolved Hide resolved
@CasperWA CasperWA added Priority: High High priority issue/PR BLOCKING Blocking issue/PR labels Oct 10, 2022
CasperWA and others added 4 commits October 10, 2022 10:54
Remove already implemented suggested future
development.

Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
@CasperWA CasperWA changed the title Clean up repository Clean up repository & fix workflows Oct 10, 2022
Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the style discussion starts to converge... the best would be if it is possible to find time for quickly agree on the best practices we want to follow.

@CasperWA
Copy link
Contributor Author

I think the style discussion starts to converge... the best would be if it is possible to find time for quickly agree on the best practices we want to follow.

This might not be "quickly" done, but we have indeed started a wiki document internally to outline these best practices. Please see our internal chat thread.

@CasperWA CasperWA merged commit 8ef8b4e into main Oct 12, 2022
@CasperWA CasperWA deleted the cwa/fix-1-2-clean-up branch October 12, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKING Blocking issue/PR Priority: High High priority issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable proper release workflow Fix workflows so they succeed Clean up newly initialized Python API
3 participants