Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved CI/CD workflows depending on SINTEF to another folder #29

Closed
wants to merge 1 commit into from

Conversation

jesper-friis
Copy link
Contributor

Incompatibilities between the CI/CD tools breaks all commits. To work around this we turn off the CI/CD using the new SINTEF repo for now.

The real issue is that mkdocs requires all methods to be annotated.

However, when adding the required annotations, the __new__()method should return an instance of the class. But mypy don't understand that it is completely valid for a __new__() method of a class that subclasses str to assign the return value to a str.

This is a bug in mypy, but it blocks any merge of PRs.

@codecov-commenter
Copy link

Codecov Report

Base: 71.02% // Head: 71.02% // No change to project coverage 👍

Coverage data is based on head (385f410) compared to base (a8491a3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   71.02%   71.02%           
=======================================
  Files           6        6           
  Lines         528      528           
=======================================
  Hits          375      375           
  Misses        153      153           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jesper-friis
Copy link
Contributor Author

Fixed in PR #32

Closing

@sygout sygout deleted the turn-off-failing-ci-cd branch July 10, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants