-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced the use of namespaces #195
Conversation
Added extend_namespace() utility function and more tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 78.42% 78.43% +0.01%
==========================================
Files 18 18
Lines 1599 1651 +52
==========================================
+ Hits 1254 1295 +41
- Misses 345 356 +11 ☔ View full report in Codecov by Sentry. |
…n warning for backward compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I especially like to better introduction. However, there are quite a few lines not tested. I think these should be added.
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
…lestore` argument to Triplestore.bind() in the tutorial.
…SBL/tripper into 194-namespace-cache-and-extension
Added some more tests, but:
|
if base_iri: | ||
warnings.warn("base_iri", UnusedArgumentWarning, stacklevel=3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but please explain in the Docstring why base_iri is a valid Argument
…SBL/tripper into 194-namespace-cache-and-extension
Description
Simplified and improved the usability of namespaces
cachemode
argument with the simple boolean argumentreload
triplestore_url
argumentformat
argument for supporting loading ontologies in formats other than turtleTriplestore.bind()
method to make it simpler to use.Closes #194
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.