Mapping function plugin system #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesper-friis
changed the title
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 75.21% 76.05% +0.84%
==========================================
Files 17 17
Lines 1416 1491 +75
==========================================
+ Hits 1065 1134 +69
- Misses 351 357 +6 ☔ View full report in Codecov by Sentry. |
…on-repo-plugin-system
…L/tripper into 128-function-repo-plugin-system
…L/tripper into 128-function-repo-plugin-system
jesper-friis
changed the title
jesper-friis
commented
Jan 12, 2024
jesper-friis
commented
Jan 12, 2024
tests/test_eval_function.py
Outdated
| func_name="ufloat", | ||
| module_name="uncertainties", | ||
| # package_name="uncertainties", | ||
| pypi_package_name="uncertainties", |
There was a problem hiding this comment.
Add version number
quaat
approved these changes
Jan 22, 2024
| if not kwargs: | ||
| kwargs = {} | ||
|
|
||
| # FIXME: Add sandboxing |
There was a problem hiding this comment.
Is there an issue to address this FIXME?
There was a problem hiding this comment.
An issue has now been created: #167
|
@jesper-friis Merge at your own convenience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #128
See #128 for design and reasoning behind this PR. Needed for using mapping functions in OTEAPI pipelines.
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.