Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): domain dont-scan list #46

Merged
merged 3 commits into from
Jun 1, 2018
Merged

feat(api): domain dont-scan list #46

merged 3 commits into from
Jun 1, 2018

Conversation

sydneyli
Copy link
Contributor

fixes #43. made a new issue for blacklisting IPs, since it'll be more involved (this would have to happen after the MX host lookup in the checker).

Also moved godotenv to main.go since we're using env vars in api as well as db now.

@sydneyli sydneyli requested a review from vbrown608 May 31, 2018 16:39
main.go Outdated
@@ -41,7 +44,24 @@ func ServePublicEndpoints(api *API, cfg *db.Config) {
log.Fatal(http.ListenAndServe(portString, mainHandler))
}

func loadDontScan() map[string]bool {
filepath := os.Getenv("DOMAIN_BLACKLIST")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make this optional by returning an empty map if DOMAIN_BLACKLIST isn't set?

@vbrown608 vbrown608 merged commit 4e214e6 into master Jun 1, 2018
vbrown608 pushed a commit that referenced this pull request Jul 13, 2018
Add comment column to Edit Log (Command Log).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blacklist certain domains from a txt file.
2 participants