Bugfix for #83 - materialsmonitor #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor.json files but you may want to create a backup for testing this branch just to be safe. - Revises the material so that it consistently uses the edname as a key, rather than using a mixture of the material name and the material edname (collectively: material). Add edname to the json. - Preserves current user settings while converting to the new edname version of the json - Adds a DeprecatedMaterials function to Materials.cs to identify and prune old data (this will be obsolete / no longer required once everyone is transitioned from the current json format) - Revises logic to make the materialsmonitor more "self-healing". The 1st time is is run it'll add an EDName to all of the entries in materialmonitor.json. The 2nd time, it'll identify any entries with the duplicate EDNames and select entries such that only one EDName shall be allowed for each material. (This happens often enough naturally that programming a loop to iterate through this process isn't necessary.)
richardbuckle
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be safe, but backup your materialsmonitor.json before testing just in case.