Skip to content

Commit

Permalink
Allow remainingDays to be null - it is not always reported.
Browse files Browse the repository at this point in the history
  • Loading branch information
Tkael committed Jul 3, 2023
1 parent eae9779 commit 9a89812
Show file tree
Hide file tree
Showing 10 changed files with 12 additions and 9 deletions.
2 changes: 1 addition & 1 deletion DataDefinitions/ThargoidWar.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class ThargoidWar
public FactionState CurrentState { get; set; }

[PublicAPI( "The number of remaining days in the current phase of the Thargoid war." )]
public int remainingDays { get; set; }
public int? remainingDays { get; set; }

[PublicAPI( "The next phase of the Thargoid war, if success is not achieved, as a localizable object." )]
public FactionState FailureState { get; set; }
Expand Down
3 changes: 3 additions & 0 deletions EDDI/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ Full details of the variables available for each noted event, and VoiceAttack in
* Revised speech service to make rendering even more thread-safe when transitioning between the `Play()` function and normal speech (#2549).
* Revised speech service to retry using speech stripped of SSML tags when speech fails using the System.Speech synthesizer.
* Worked around a journal bug when `HullHealth` is not written to the player journal `Loadout` event. (#2552)
* Speech Responder
* Changes to existing scripts
* `System state report` updated to allow thargoid war `remainingDays` to be null (since for some states it is not present in the journal output).

## 4.0.3-b3
* Core
Expand Down
2 changes: 1 addition & 1 deletion SpeechResponder/eddi.cs.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion SpeechResponder/eddi.de.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion SpeechResponder/eddi.hu.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion SpeechResponder/eddi.it.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion SpeechResponder/eddi.ja.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion SpeechResponder/eddi.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion SpeechResponder/eddi.ru.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Tests/JournalMonitorTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1070,7 +1070,7 @@ public void TestJumpedEventThargoidProbing ()
Assert.AreEqual( FactionState.ThargoidControlled, @event.ThargoidWar.FailureState );
Assert.IsTrue( @event.ThargoidWar.succeeded );
Assert.AreEqual( 100M, @event.ThargoidWar.progress );
Assert.AreEqual( 0, @event.ThargoidWar.remainingDays );
Assert.AreEqual( null, @event.ThargoidWar.remainingDays );
Assert.IsNull( @event.ThargoidWar.remainingPorts );
}

Expand Down

0 comments on commit 9a89812

Please sign in to comment.