Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Structure rules test coverage #27

Merged
merged 3 commits into from
Feb 22, 2024
Merged

MAINT: Structure rules test coverage #27

merged 3 commits into from
Feb 22, 2024

Conversation

carlwilson
Copy link
Member

  • added case by case tests and data for structural conditions;
  • fixed bugs in the structure checking code based on results of the above; and
  • added test data for the above.

@carlwilson
MAINT: Structure rules test coverage
f7f6ae9 
- added case by case tests and data for structural conditions;
- fixed bugs in the structure checking code based on results of the above; and
- added test data for the above.
@carlwilson carlwilson self-assigned this Feb 22, 2024
@carlwilson carlwilson added the bug Something isn't working label Feb 22, 2024
@carlwilson carlwilson changed the base branch from refact/specifications to integration February 22, 2024 13:54
darrendignam
darrendignam approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@darrendignam darrendignam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built the package against python 3.11
It passes the automated builds for the other supported versions.

I see no issues within the commits that would cause concern

@carlwilson carlwilson merged commit d0b9994 into integration Feb 22, 2024
4 checks passed
@carlwilson carlwilson deleted the maint/struct-test-coverage branch February 22, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrendignam darrendignam darrendignam approved these changes

Assignees

@carlwilson carlwilson

Labels
bug Something isn't working
Projects
E-ARK CSP CORE.3 Validation Framework
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlwilson @darrendignam