Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACT: Cleanup rulesets and requirements. #25

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Conversation

carlwilson
Copy link
Member

  • cleaned up StructuralRequirements some;
  • fixed broken property getters in EarkSpecifications;
  • better tests for specifications and requirements;
  • made generators from SchematronRuleset properties; and
  • prettier printing from the CLI using rich.

- cleaned up `StructuralRequirements` some;
- fixed broken property getters in `EarkSpecifications`;
- better tests for specifications and requirements;
- made generators from `SchematronRuleset` properties; and
- prettier printing from the CLI using `rich`.
@carlwilson carlwilson self-assigned this Feb 21, 2024
Copy link
Collaborator

@darrendignam darrendignam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tidying up and make the classes more strictly defined, and the changes to some function names to be more descriptive is a welcome addition.

I see no issues with any of the tests.

@carlwilson carlwilson merged commit ff9fe95 into integration Feb 22, 2024
4 checks passed
@carlwilson carlwilson deleted the refact/rulesets branch February 22, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants