MAINT: Quick package publication #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed use of `to_upper` and use of `model_validate()` to force upper case checksum values; - catch `str` initialization of `Checksummer` so that a valid `ChecksumAlg` is always used; and - added test for case insensitivity of checksum values.
- `eark_validator/cli/app.py`: - validation now uses `eark_validator.model.ValidationReport` module; - improved `argparse` docs a little; - updated epilog date; - `eark_validator/infopacks/manifest.py`: - `FileItem` and `Manifest` types moved to appropriate `model` modules; - `ManifestEntries` and `Manifests` classes now hold API/factory methods for above; - no more `Checksum`s from METS files; - uses `Path` rather than `str` for file paths; - `eark_validator/mets.py b/eark_validator/mets.py`: - METS validation moved to `MetsFiles` class; - use `FileItem` rather than `FileEntry` types for file lists; - utility methods for `FileEntry` added; - added file headers where missing; - added a `SchematronRuleset.get_reports()` genrator method; - improved type hints here and there; - better/refactored tests; and - fixed imports post-refactoring.
- added `pickle` based serialisation and deserialisation for `Manifest` class; - manifests can now be validated against an alternative root; - fixed faulty `|` as `or` in `MetsFiles.from_file()` method; - model `MetsFile.default_ns` is now a dictionary of namespace prefixes and URIs; - fixed handling of relative paths during Manifest creation/validation; - improved testing of manifest classes; and - typehints here and there.
- loose model types for InformationPackages, plus removed defunct types; - JSON output from Pydantic types; - changed application name from `ip-check` to `eark-validator`; - streamline application/project versioning; - updated `./README.md` to reflect name change and pre-requisites; - removed Python 3.9 build and updated docs to Python 3.10; and - updated lxml dependency.
- fixed workflow to get tags when available; - recofigured `setuptools-git-versioning` so no VERSION file; and - removed VERSION file.
shsdev
approved these changes
Feb 16, 2024
This was
linked to
issues
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ip-checktoeark-validator;./README.mdto reflect name change and pre-requisites;