Fix/csip88 deprecated assertion message #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the deprecated CSIP86 requirement. Replaced with text from CSIP88.
carlwilson
approved these changes
Feb 1, 2024
carlwilson
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Any chance that you could look at retrospectively signing these commits please @Sunday-Crunk ? I'll relax the restriction if necessary but it's good practice. The instructions are here and possibly here for CLI retrospective signing.
|
Roger that @carlwilson , thanks for the tip. As you can tell my git-fu is quite lacking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow or another the validation message for CSIP88 has been mixed up with that from CSIP86, which has been deprecated. I have replaced it with the requirement text. The schematron is still functional.