Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-7391: As a Dynamo dev, I want to update ASM component support for Global Launch #15506

Merged
merged 12 commits into from
Oct 3, 2024
Merged

DYN-7391: As a Dynamo dev, I want to update ASM component support for Global Launch #15506

merged 12 commits into from
Oct 3, 2024

Conversation

sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Sep 24, 2024 •
edited
Loading

Purpose

This Pull Request does:

  • add support for Autodesk Shared Components (ASC) to the Install Detective.
  • add unit tests covering the new ASC wrapper functionality
  • add support for ASM 231

Notes:

  • The install detective is now looking for files both in installed host products and installed ASC components. We will eventually stop looking in installed host products and rely only on ASC.
  • Dynamo still supports ASM 230.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Added support for ASM 231 and Autodesk Shared Components in preparation for Global launch

Reviewers

FYIs

@sm6srw sm6srw added the WIP label Sep 24, 2024
@github-actions github-actions bot changed the title As a Dynamo dev, I want to update ASM component support for Global Launch DYN-7391: As a Dynamo dev, I want to update ASM component support for Global Launch Sep 24, 2024
github-actions[bot]
github-actions bot reviewed Sep 24, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7391

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang added this to the 3.4 milestone Sep 30, 2024
@sm6srw sm6srw removed the WIP label Oct 2, 2024
@sm6srw sm6srw requested a review from QilongTang October 2, 2024 15:40
QilongTang
QilongTang reviewed Oct 2, 2024
View reviewed changes
src/DynamoCore/DynamoCore.csproj
<LibGProtoGeometryDLL Include="$(PkgDynamoVisualProgramming_LibG_230_0_0)\tools\netstandard2.0\$(LibGOsToken)\ProtoGeometry.dll" />
<LibGProtoGeometryXML Include="$(PkgDynamoVisualProgramming_LibG_230_0_0)\tools\netstandard2.0\$(LibGOsToken)\ProtoGeometry.XML" />
<LibG230Deps Include="$(PkgDynamoVisualProgramming_LibG_230_0_0)\tools\netstandard2.0\$(LibGOsToken)\asm_deps.csproj" />
<LibGProtoGeometryUICulture Include="$(PkgDynamoVisualProgramming_LibG_230_0_0)\tools\netstandard2.0\$(LibGOsToken)\$(UICulture)\*" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why the 230 related ones needs to be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always link against the latest version of LIBG. But we load the one that corresponds to the ASM version found.

QilongTang
QilongTang reviewed Oct 2, 2024
View reviewed changes
src/Tools/DynamoInstallDetective/ProductLookUp.cs Outdated
public class InstalledAscLookUp : InstalledProductLookUp
{

public InstalledAscLookUp(string fileLookup) : base(@"Autodesk Shared Components", fileLookup)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we define @"Autodesk Shared Components" as a const string?

QilongTang
QilongTang approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments. Please confirm, for a case where both ASC components and ASM binaries exist for a particular product, the ASM Dynamo decides to load is determined by the latest version or sequence?

@sm6srw
Copy link
Contributor Author

sm6srw commented Oct 2, 2024 •
edited
Loading

LGTM with some comments. Please confirm, for a case where both ASC components and ASM binaries exist for a particular product, the ASM Dynamo decides to load is determined by the latest version or sequence?

I have added more comments. Take a look and let me know if it is clearer now.

In general: First, Highest ASM version wins. Second, ASC wins over product.

@QilongTang
Copy link
Contributor

Rerunning unit tests on https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16494/

@sm6srw
Copy link
Contributor Author

sm6srw commented Oct 3, 2024

Passed!

@sm6srw sm6srw merged commit ef9bacc into master Oct 3, 2024
23 of 24 checks passed
@sm6srw sm6srw deleted the DYN-7391 branch October 3, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@sm6srw @QilongTang