Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5709: publish version fix #15408

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jul 26, 2024

Purpose

Following up on a https://jira.autodesk.com/browse/DYN-5709, this PR addresses a bigger concern. The Publish Version experience has been broken for a while now. After a lengthy research and trying several options, the proposed solution is very simple.

Context - the retain folder structure option was introduced as an alternative way to publish a package. It was modeled after the existing and only way, which lead Dynamo predefine a set of 4 folders (bin, doc, dyf, extra), and allocate packages accordingly. As one of the steps, this flow would check and delete pre-existing files in the above locations before copying the files to a finalize package structure. This made sense, as the files would come from a separate place to be copied in this new package folder structure.

In contrast, the retain folder structure takes files and folders exactly as they are, and copies them to the default package folder, so the final package is loaded in Dynamo and ready to use. However, in case there is a folder already installed locally, and the user needs to submit it for the first time online, or submit it as a new version, the source files will be the same as the target files. In this case, it makes no sense to try to override the file with the same file, so we simply skip it.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • fixing the publish version workflow by removing the deletion of existing files from the 'retain folder structure' route
  • a few minor issues found, fix

Reviewers

@aparajit-pratap
@reddyashish
@QilongTang
@zeusongit

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

- fixing the publish version workflow by removing the deletion of existing files from the 'retain folder structure' route
- a few minor issues found, fix
@github-actions github-actions bot changed the title publish version fix DYN-5709: publish version fix Jul 26, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-5709

Copy link

github-actions bot commented Jul 26, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@dnenov
Copy link
Collaborator Author

dnenov commented Jul 26, 2024

There was a good investigation done regarding the use PackageLoadContext, just making a not of it here #15406

- solves the purpose of publish for the first time vs publish a version online
@reddyashish reddyashish merged commit 27e54c8 into DynamoDS:master Jul 26, 2024
25 checks passed
@QilongTang QilongTang added this to the 3.3 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants