cherrypick DYN-6728 feature flags should be controlled by no network mode when c… #14980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reating a dynamo model directly. (DynamoDS#14975) * check network mode * align disable and networkmode * add small tests * remove todo * review comments * another test
QilongTang
approved these changes
Feb 27, 2024
QilongTang
reviewed
Feb 27, 2024
|
|
||
| // If user skipped analytics from assembly config, do not try to launch the analytics client | ||
| // or the feature flags client for web traffic reason. | ||
| if (!IsServiceMode && !areAnalyticsDisabledFromConfig && !Analytics.DisableAnalytics) | ||
| if (!IsServiceMode && !areAnalyticsDisabledFromConfig && !Analytics.DisableAnalytics && !NoNetworkMode) |
There was a problem hiding this comment.
I thought Analytics.DisableAnalytics = NoNetworkMode || Analytics.DisableAnalytics; above is already covering it because !Analytics.DisableAnalytics is used here?
There was a problem hiding this comment.
it does cover it, but I think moving forward we really should be using checking NoNetworkMode separately everywhere - and I will file a task to look into that - as this bug shows, not everyone uses the same code paths when starting Dynamo if they write their own entry points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cp:
#14975