[DYN-6451] Analytics for ML DataPipeline. #14936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
Do we need another PR on the Analytics repo to add the Category in whitelist file? |
QilongTang
reviewed
Feb 13, 2024
| @@ -78,6 +78,8 @@ public static string ConstructCreateAssetRequestBody(string schemaNamespaceId, s | |||
| parameterComponent.AddParameterFromSchema("<Add dynamo host>", hostSchema); | |||
| parameterComponent.AddParameterFromSchema("<Add dynamo version>", dynamoVersionSchema); | |||
|
|
|||
| Analytics.TrackEvent(Actions.DynamoMLDataPipieline, Categories.DynamoMLDataPipelineOperations, "Host", Convert.ToInt32(hostSchema)); | |||
There was a problem hiding this comment.
Isn't host name already part of each data entry? Do we still need to send it separately?
There was a problem hiding this comment.
Do you mean Dynamo already sends host info(during startup or after it) to analytics, so we don't need it here. I was thinking we might want to know which host is sending a request to the ML pipeline and thats why we need it here. What do you think? It was added in the JIRA task.
QilongTang
reviewed
Feb 13, 2024
QilongTang
reviewed
Feb 14, 2024
QilongTang
approved these changes
Feb 16, 2024
|
Please also cherry-pick |
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
Feb 23, 2024
* ML DataPipeline analytics * comments * comments * Update DynamoMLDataPipeline.cs (cherry picked from commit dd9c7af)
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Task: https://jira.autodesk.com/browse/DYN-6451
This PR is to add Analytics to the ML DataPipeline workflow. Sending the following info:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Analytics for ML DataPipeline.
Reviewers
@QilongTang @zeusongit