Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full path to dynamo in tests #14934

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

pinzart90
Copy link
Contributor

@pinzart90 pinzart90 commented Feb 12, 2024

Some parts of Dynamo expect the full path to DynamoCore (as supplied in Tests)
Ex. All code that tries to load assemblies via Assembly.LoadFile(DynamoCorePath + "some_dll") will fail fi the DynamoCorePath is not fully qualified.

Some DynamoSamples tests fail to run because some resource assembly in Dynamo cannot be found (Dynamo tries to load it via Assembly.LoadFile(DynamoCorePath + "some_resource_file"))

Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@mjkkirschner
Copy link
Member

@pinzart90 ah interesting, will this help resolve the test discovery failing or is that separate?

@pinzart90 pinzart90 merged commit c46b0fe into master Feb 13, 2024
21 checks passed
@pinzart90 pinzart90 deleted the full_path_dynamo_test_config branch February 13, 2024 02:29
@pinzart90
Copy link
Contributor Author

@pinzart90 ah interesting, will this help resolve the test discovery failing or is that separate?

Sadly, not the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants