DYN-6626: Add paneling nodes as an experimental feature #14920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Smoke TestsTest: success. 2 passed, 0 failed. |
| <data name="PreferencesViewEnablePanelNodes" xml:space="preserve"> | ||
| <value>Enable Panel nodes</value> |
There was a problem hiding this comment.
I'm not happy with the protogeometry class name - Panel as it actually represents a panel-mesh instead of a single panel. I'll probably change it after I get some initial feedback. On a similar note, I think Enable Paneling nodes would be more appropriate here.
aparajit-pratap
approved these changes
Feb 8, 2024
|
There might be similar changes in #14923 you want to look at, do you plan to use feature flag to control the visibility? |
sm6srw
changed the title
aparajit-pratap
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-6626: Add paneling nodes as an experimental feature
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Add paneling nodes as an experimental feature
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of