Skip to content

Refactor python engines api #12

Refactor python engines api

Refactor python engines api #12

Triggered via pull request February 14, 2024 21:29
Status Success
Total duration 7m 54s
Artifacts

dynamo_api_break.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
analyze
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: microsoft/setup-msbuild@v1.3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
analyze: src/DynamoUtilities/Option.cs#L373
'Option._None<T>' defines operator == or operator != but does not override Object.Equals(object o)
analyze: src/DynamoUtilities/Option.cs#L373
'Option._None<T>' defines operator == or operator != but does not override Object.GetHashCode()
analyze: src/DynamoUtilities/AssemblyConfiguration.cs#L12
Field 'AssemblyConfiguration.instance' is never assigned to, and will always have its default value null
analyze: src/NodeServices/PythonServices.cs#L271
Parameter 'logger' has no matching param tag in the XML comment for 'PythonEngineManager.LoadPythonEngine(Action<string>, IEnumerable<Assembly>)' (but other parameters do)
analyze: src/Engine/ProtoCore/AssociativeGraph.cs#L1579
'UpdateNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
analyze: src/Engine/ProtoCore/AssociativeGraph.cs#L1622
'UpdateNodeRef' overrides Object.Equals(object o) but does not override Object.GetHashCode()
analyze: src/Engine/ProtoCore/DSASM/DSString.cs#L6
'DSString' overrides Object.Equals(object o) but does not override Object.GetHashCode()
analyze: src/Engine/ProtoCore/ProcedureTable.cs#L53
'ProcedureNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
analyze: src/Engine/ProtoCore/SymbolTable.cs#L7
'SymbolNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
analyze: src/Engine/ProtoCore/CodeFile.cs#L5
'CodeFile' defines operator == or operator != but does not override Object.Equals(object o)