Prevent override of bye completed match

Drarig29 · Jul 11, 2023 · 0dc87c1 · 0dc87c1
1 parent f4f184a
commit 0dc87c1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/helpers.ts b/src/helpers.ts
@@ -677,7 +677,7 @@ export function isMatchByeCompleted(match: DeepPartial<MatchResults>): boolean {
  * @param match The match to check.
  */
 export function isMatchUpdateLocked(match: MatchResults): boolean {
-    return match.status === Status.Locked || match.status === Status.Waiting || match.status === Status.Archived;
+    return match.status === Status.Locked || match.status === Status.Waiting || match.status === Status.Archived || isMatchByeCompleted(match);
 }
 
 /**

diff --git a/test/double-elimination.spec.js b/test/double-elimination.spec.js
@@ -184,6 +184,12 @@ describe('Previous and next match update in double elimination stage', () => {
             loserId,
         );
 
+        await assert.isRejected(manager.update.match({
+            id: 3, // First match of LB round 1
+            opponent1: { score: 16, result: 'win' },
+            opponent2: { score: 12 },
+        }), 'The match is locked.');
+
         await manager.reset.matchResults(1); // Second match of WB round 1
 
         matchSemiLB = await storage.select('match', 3);