Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Selct, Cascader suffix icon style error #2493

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Sep 12, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #
修改后:依次为 Cascader,TreeSelect,Select
image

Changelog

🇨🇳 Chinese

  • Fix: 修复 Cascader 在有 suffix 并设置了 showClear 的情况下,清除图标位置和清除图标位置不同问题
  • Style: 修改 Select 在设置 suffix 情况下,后缀和下拉图标的位置关系未与 TreeSelect/Cascader 保持一致问题(如有其他位置需求,可通过设置 flex 的 order 属性自行调整位置)

🇺🇸 English

  • Fix: Fixed the problem that when Cascader has suffix and showClear is set, the position of the clear icon and the position of the clear icon are different.
  • Style: Modify the problem that when suffix is ​​set in Select, the positional relationship between the suffix and the drop-down icon is not consistent with TreeSelect/Cascader. ((If you have other position requirements, you can adjust the position by setting the order attribute of flex))

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b5454b4:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Sep 12, 2024

semi-design    Run #2809

Run Properties:  status check passed Passed #2809  •  git commit f6ee54ff38 ℹ️: Merge b5454b418a19b1a40cbfd5d1cb21006069d8775d into d93b90a805302800ce6924e32ebc...
Project semi-design
Branch Review fix/suffix
Run status status check passed Passed #2809
Run duration 09m 09s
Commit git commit f6ee54ff38 ℹ️: Merge b5454b418a19b1a40cbfd5d1cb21006069d8775d into d93b90a805302800ce6924e32ebc...
Committer YyumeiZhang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 263
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pointhalo pointhalo merged commit edc172d into main Sep 13, 2024
10 checks passed
@pointhalo pointhalo deleted the fix/suffix branch September 13, 2024 03:04
Copy link

cypress bot commented Sep 13, 2024

semi-design    Run #2814

Run Properties:  status check passed Passed #2814  •  git commit edc172dda8: fix: fix Selct, Cascader suffix icon style error (#2493)
Project semi-design
Branch Review main
Run status status check passed Passed #2814
Run duration 07m 38s
Commit git commit edc172dda8: fix: fix Selct, Cascader suffix icon style error (#2493)
Committer YyumeiZhang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 263
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants