Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve translate of datepicker in vi_vn #2486

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Conversation

pointhalo
Copy link
Collaborator

@pointhalo pointhalo commented Sep 12, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

在 Datepicker 日期选择器中,日历头部的 周一到周日 文本,会适配不同语言,显示对应的文本。
如下,分别为英文、中文时显示的文案
image
image

而在马来语中,会超长
image
因此根据译员建议,采用缩写,优化后效果如下
image

  • 另外 Table的展示也根据译员建议对日语、印尼语的 总页数等显示文案做了调整

Changelog

🇨🇳 Chinese

  • Fix: 优化 Datepicker 在马来语、俄语、越南语、阿拉伯语 的星期一-星期日的文案展示; 优化 Table 左下角文案在日语、印尼语、越南语时的展示。

🇺🇸 English

  • Fix: Optimized Datepicker Copywriting in Malay (ms_MY), Russian(ru_RU), Vietnamese(vi_VN), Arabic(ar) Monday - Sunday. Optimize the display of text in Japanese, Indonesian, and Vietnamese in the lower left corner of the Table.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Sep 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c5ddeab:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Sep 12, 2024

semi-design    Run #2804

Run Properties:  status check passed Passed #2804  •  git commit 9b9c908b68 ℹ️: Merge c5ddeab821288d03c5dc51bb74e30ef308220711 into ff810ec47ddba1b249be96c460ac...
Project semi-design
Branch Review locale-datepicker
Run status status check passed Passed #2804
Run duration 07m 59s
Commit git commit 9b9c908b68 ℹ️: Merge c5ddeab821288d03c5dc51bb74e30ef308220711 into ff810ec47ddba1b249be96c460ac...
Committer pointhalo
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 263
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pointhalo pointhalo merged commit a858925 into main Sep 12, 2024
9 checks passed
@pointhalo pointhalo deleted the locale-datepicker branch September 12, 2024 08:00
Copy link

cypress bot commented Sep 12, 2024

semi-design    Run #2805

Run Properties:  status check passed Passed #2805  •  git commit a858925310: fix: improve translate of datepicker in vi_vn/ms_MY (#2486)
Project semi-design
Branch Review main
Run status status check passed Passed #2805
Run duration 07m 44s
Commit git commit a858925310: fix: improve translate of datepicker in vi_vn/ms_MY (#2486)
Committer pointhalo
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 263
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant