Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Avatar/AvatarGroup size type error #2459

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Aug 29, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2446 #2443
原来 Avatar/AvatarGroup 的size 属性只支持在可选值,#2290 中扩展了到支持其他的合法宽度值,ts 定义未修改。

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Aug 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 737b5a7:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Aug 30, 2024

semi-design    Run #2773

Run Properties:  status check failed Failed #2773  •  git commit 0a0d5a0ab3 ℹ️: Merge 737b5a77b338ffef1108586dcd8a7bee0ae89972 into fd051c8198574d79799e7e6e6779...
Project semi-design
Branch Review type/avatar
Run status status check failed Failed #2773
Run duration 09m 56s
Commit git commit 0a0d5a0ab3 ℹ️: Merge 737b5a77b338ffef1108586dcd8a7bee0ae89972 into fd051c8198574d79799e7e6e6779...
Committer YyumeiZhang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 267
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/slider.spec.js • 1 failed test • Cypress - Chrome

View Output Video

Test Artifacts
slider > controlled slider with onChange Screenshots Video

@DaiQiangReal DaiQiangReal merged commit be6e011 into main Sep 2, 2024
7 of 9 checks passed
@DaiQiangReal DaiQiangReal deleted the type/avatar branch September 2, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Avatar] 自定义头像大小时ts类型检测错误
2 participants