Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of FBINFO_CAN_FORCE_OUTPUT #148

Closed
wants to merge 1 commit into from
Closed

Remove use of FBINFO_CAN_FORCE_OUTPUT #148

wants to merge 1 commit into from

Conversation

exFalso
Copy link

@exFalso exFalso commented Jan 21, 2019

The flag was removed in 4.20, see https://patchwork.kernel.org/patch/10572741/

@jhall-pinoak
Copy link

Thanks, this completely fixed issue for me. I am on this kernel:Linux version 4.20.3-200.fc29.x86_64 (mockbuild@bkernel04.phx2.fedoraproject.org) (gcc version 8.2.1 20181215 (Red Hat 8.2.1-6) (GCC)) #1 SMP Thu Jan 17 15:19:35 UTC 2019

@displaylink-dkurek
Copy link
Contributor

We are preparing new release which will address problems with compatibility with new kernels. We have already fix for 4.20 kernel in our '#if #else' style

@stdweird stdweird mentioned this pull request Jan 23, 2019
Closed
@wwahammy wwahammy mentioned this pull request Jan 25, 2019
Closed
@gbraad
Copy link

gbraad commented Feb 12, 2019

@displaylink-dkurek @displaylink-mlukaszek Any ETA?

@gbraad gbraad mentioned this pull request Feb 13, 2019
Closed
gbraad
gbraad reviewed Feb 13, 2019
View reviewed changes
Copy link

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check for kernel version

module/evdi_fb.c
@@ -367,7 +367,7 @@ static int evdifb_create(struct drm_fb_helper *helper,
info->fix.smem_len = size;
info->fix.smem_start = (unsigned long)ufbdev->ufb.obj->vmapping;

info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
info->flags = FBINFO_DEFAULT;
Copy link

@gbraad gbraad Feb 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

-	info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
+	#if KERNEL_VERSION(4, 20, 0) <= LINUX_VERSION_CODE
+	info->flags = FBINFO_DEFAULT;
+	#else
+	info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
+	#endif

gbraad
gbraad suggested changes Feb 13, 2019
View reviewed changes
Copy link

@gbraad gbraad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check for kernel version

@displaylink-dkurek
Copy link
Contributor

@gbraad You are right about the kernel versions.

New stuff should be 'live' early next week; both EVDI and DisplayLinkManager.

@displaylink-dkurek
Copy link
Contributor

displaylink-dkurek commented Feb 19, 2019 •
edited
Loading

So, finally its there :)
evdi repository has been updated with quite some number of changes.
We are shifting towards 'atomic modeset', which means we are dropping
support for kernels older than 4.2.
With this change we did bump-up the evdi/libevdi versions, so for compatibility
please install new DisplayLinkManager (v5.1), which can be downloaded from here:
https://www.displaylink.com/downloads/ubuntu
Hope you will like it ;)

(I will just copy&paste this message to wherever it fits ;p)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbraad gbraad gbraad requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@exFalso @jhall-pinoak @displaylink-dkurek @gbraad