-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel 5.9 breaks DisplayLink #225
Comments
If you wish I have a testing patch, untested since I don't have any HW to test right now and will only work with a 5.9 kernel. Patch against latest release: |
That’s great. Will test when back home. Guessing it was just a one liner allowing 5.9.x to pass? Or is there more to it?
…Sent from my iPhone
On 13 Oct 2020, at 12:06, abucodonosor ***@***.***> wrote:
If you wish I have a testing patch, untested since I don't have any HW to test right now and will only work with a 5.9 kernel.
Patch against latest release:
https://crazy.dev.frugalware.org/evdi-kernel-5.9-test.patch
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I see there’s quite a bit more to it 😉
Just a heads up, I’m on AMD Ryzen 7 (Radeon + Nvidia).
…Sent from my iPhone
On 13 Oct 2020, at 12:06, abucodonosor ***@***.***> wrote:
If you wish I have a testing patch, untested since I don't have any HW to test right now and will only work with a 5.9 kernel.
Patch against latest release:
https://crazy.dev.frugalware.org/evdi-kernel-5.9-test.patch
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
It is a bit more than a one-liner:). The Intel workaround is now somewhat strange but it should, in theory, work like this. |
Oooof, n00b to patching (can read them, but not applied before)... Where's
likely to be the path to my DisplayLink?
Ubuntu... Latest DL from website...
Seeing this:
"patch < '/home/robsta/Downloads/evdi-kernel-5.9-test.patch'
can't find file to patch at input line 4
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Naur evdi-1.8.0/module/evdi_cursor.c
evdi-1.8.0-p/module/evdi_cursor.c
|--- evdi-1.8.0/module/evdi_cursor.c 2020-07-31 12:07:08.000000000 +0200
|+++ evdi-1.8.0-p/module/evdi_cursor.c 2020-10-12 16:05:56.615556087 +0200
--------------------------
File to patch: "
…On Tue, 13 Oct 2020 at 14:49, abucodonosor ***@***.***> wrote:
@robotard <https://github.com/robotard>
It is a bit more than a one-liner:).
The Intel workaround is now somewhat strange but it should, in theory,
work like this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#225 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB6C4MOMBYUJOKDUHHSGBTSKRLGLANCNFSM4SOANJSA>
.
|
@robotard @abucodonosor I've just checked it with evdi master and v1.7.0 tag - compiles fine. Note: For usage with DisplayLinkManager 5.3.1 please apply it on Something like this should work: # get sources
git clone https://github.com/DisplayLink/evdi.git
cd evdi
git checkout v1.7.0
# patch
curl https://crazy.dev.frugalware.org/evdi-kernel-5.9-test.patch | patch -Np1
# install
make
sudo make install
# reboot |
I can do an PR. What is the rule now regarding #ifdef's for kernels?
IOW, newest changes first in form of <= ? |
Yes, exactly. Please use only |
Ok done. |
Works for the 1.7.0 tag too, thanks @abucodonosor & @displaylink-dkurek! Master was 1 ahead of 1.7.0 tag which worked for me too, any reason why tag was one behind, @displaylink-dkurek? |
Unfortunately no bueno for me
Thanks again for another swift response :) Unfortunately no bueno for me here... I dis mention that I'm a Groovy Gorilla (20.10) too right? Here's my kernel info: I've attached the DLSupportTool output for your perusal too, and am more than happy to do any testing you need for both this fix, and anything that I may be able to help with in the future... Am usually close to latest Ubuntu/Kernel versions too :) |
Working on 5.9 with 1.7.0, love you @abucodonosor git clone https://github.com/DisplayLink/evdi
cd evdi
git checkout -f master
git remote add abucodonosor https://github.com/abucodonosor/evdi.git
git fetch --all
git cherry-pick abucodonosor/issue-225 --no-commit
make Or git clone https://github.com/sickcodes/evdi
git checkout -f master
cd evdi
make |
@sickcodes |
I tried both of these methods and it gives me error 2.
I also tried the code block in the comments of https://aur.archlinux.org/packages/displaylink but even the first line |
there is something wrong with your kernel source. You are also compiling against 5.8.11, while that should work just fine with the patch, it should work the same without. The patch only adjusts some API changes for the 5.9 kernel. |
If you haven't installed evdi-git you don't need to uninstall it. |
Yeah I tried installing I think I'll just install 5.9 kernel. Hopefully other things won't break and hopefully this will work. |
@PathosEthosLogos, do you understand the commands you are trying to execute? Because if not, please stay away from any AUR package, because you are exposing yourself to a big security risk. @sickcodes' code block does this:
Note: I do not say, you can't trust @sickcodes, but he is a random person on the internet as anyone else here is. |
Well, you are right but one can compare the fork and the original online even, right now no difference. I think you forgot to push something out in your fork? :) |
Yes, of course. master...sickcodes:master is the same as just examining https://github.com/DisplayLink/evdi/pull/228/files. But if you just replace the repo in the PKGBUILD and don't look at anything, this is dangerous.
? |
I forgot to insert the malware 🤪 |
Haha yeah, I knew all except But it seems like updating to 5.9 kernel didn't fix it. Same 'Error 2' with some additions.
|
You haven't cherry-picked @abucodonosor's changes yet you're building the DisplayLink/master |
No, you forgot devel is the default branch. so one need to clone your fork and checkout master :) |
git clone https://github.com/sickcodes/evdi will clone devel branch, your patch pulled from me doesn't exist in devel so make will fail on a 5.9 kernel:) |
That error is now different you are missing my patch :) |
Yeah you're right, need to checkout master first. The AUR PKGBUILD from @bnavigator checks out master so I am missing that in my above comment. I was supposed to commit to devel tag 1.7.0? |
No, master is correct. There is no 1.7.0 branch. |
Looks wrong. Use
or
|
Same effect really, I moved it to current directory to have a look at it 🙃 |
This comment has been minimized.
This comment has been minimized.
I see no logs. As I said, I did not test the instructions. Are you sure the patched evdi is being compiled and installed? Also, did you consult https://support.displaylink.com/knowledgebase/topics/103927-troubleshooting-ubuntu ? |
This is not the place to teach people how to do basic packaging tasks for random distributions. This is getting ridiculous, seriously. |
Oof. Before trying to call others a tool, perhaps check that your very own
DLSupportTool functions correctly.
You are hardly being useful with this necessity to have the biggest pair
here!
If you have someone willing to test your fixes, then stop being a dick
about it! Given that I had to apparently boot into a TTY session to avoid
hitting XOrg, then a small typo between retyping from my phone to my laptop
should be f*#cking acceptable.
Logs attached for you again Ben.
…On Sun, 18 Oct 2020 at 15:28, Ben Greiner ***@***.***> wrote:
sudo mv sudo is one sudo too much. Given @robotard
<https://github.com/robotard> confuses 1s with ls you have to be careful.
You could tell him to execute sudo rm -rf / and he probably would try...
😠
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#225 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB6C4J5OR53ES2Q4EHIAQDSLL3RBANCNFSM4SOANJSA>
.
|
Thanks for the helpful advice sickcodes...
I don't appear to have a rules file under udev/rules.d:
/etc/udev/rules.d$ ls
70-snap.snapd.rules 70-snap.snap-store.rules
…On Sun, 18 Oct 2020 at 11:11, sickcodes ***@***.***> wrote:
@robotard <https://github.com/robotard> try removing this file from udev,
it fixes Xorg crash for me.
Remove the udev rule.
Disable DisplayLink service
sudo modprobe evdi
sudo systemctl disable displaylink.service# removing 99-displaylink.rules is necessary for me
sudo mv sudo /etc/udev/rules.d/99-displaylink.rules .
reboot
And then start X, xfce etc.
When you're inside the desktop run:
sudo systemctl start displaylink
This is necessary for me on Xorg latest
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#225 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB6C4PDQZUTKXT4AX2LF33SLK5O7ANCNFSM4SOANJSA>
.
|
People have repeatedly told you, there are no logs attached. Please check the GitHub issue page and clean your posts. The e-mail reply feature of Github apparently does not support attachments. The fact that you don't have a udev rule, indicates you did either not run displaylink-installer.sh properly or you messed with your installation afterwards, by entering commands, which you don't understand. In any case, my patience is almost exhausted. Perhaps you should try to fix your system with the help of people over at the Ubuntu user forums instead of insulting people here. Maybe @abucodonosor is right, despite Ubuntu being the only "officially" supported distribution by DisplayLink. |
BTW, the official displaylink-installer.sh installs the systemd service as
|
Here's my 2¢ for anyone lurking: DisplayLink only works on kernel <=5.8 kernel with evdi 1.7. Evdi 1.7 is also known as evdi master because evdi 1.8 doesn't work for anyone yet, which is why there are 2 pull requests: one to fix evdi 1.8 by @abucodonosor and one to fix evdi 1.8, cherry picked by me from @abucodonosor. If you want test your DisplayLink device to work on Linux Kernel >=5.9 then you need to cherry pick @abucodonosor's perfect fix onto the master branch as seen in: But the kicker is, evdi MUST be on 1.7, hence: To test @abucodonosor's fix, Ubuntu/Debian/Arch/Manjaro/Fedora/RHEL/CentOS/Pop users would only need to force install DisplayLink, then manually install evdi 1.7 from my PR. Xorg 1.20.9 MAY crash without deleting the udev rule as specified above. In which case, try removing the udev rule as indicated above and disabling DisplayLink systemd service, and adding DisplayLink service to start AFTER your desktop loads. Arch users should use https://aur.archlinux.org/packages/evdi-1.7/ from @bnavigator. I think DisplayLink may benefit from a PPA or a custom APT sources repository (like Spotify sources https://www.spotify.com/us/download/linux/) instead of a shell script installer. |
Nobody can test 1.8 devel branch, they can only build it, hence why we are all hacking each respective distro's installer to test @abucodonosor fantastic fix on 1.7 |
But that installs the unpatched evdi first. How are you gonna make sure users correctly replace the evdi afterwards? Not to mention that DKMS has to recompile the evdi kernel module.
.. which also would be outdated until some developer there would bother to merge the patches and release a new package. DisplayLink should really make it possible for distributions to include a proper package into their official repositories. But this requires DisplayLinkManager to be open-sourced. |
Depends on your dm. The original systemd service unit has |
@robotard In reply to your logs in #228 (comment) machine_info.txt
What is the output of Here is another resource, with which you should compare the output you get on your system: And your dmesg.txt is empty, probably because you didn't run with enough privileges. |
Ubuntu related problems should probably go here https://www.displaylink.org/forum/showthread.php?t=67372 or any other suitable Ubuntu support forum |
Hi Ben,
Sorry for the late response, I had a nasty accident recently that's put me
out for over a week... From looking back through terminal, it looks as
though I didn't sudo the DLSupportTool, so have reattached here...
I've tried the following as above
sudo dkms list
Usage: /usr/sbin/dkms [action] [options]
[action] = { add | remove | build | install | uninstall | match |
autoinstall | mkdriverdisk |
mktarball | ldtarball | mkrpm | mkkmp | mkdeb | mkdsc |
mkbmdeb | status }
[options] = [-m module] [-v module-version] [-k kernel-version] [-a arch]
[-d distro] [-c dkms.conf-location] [-q] [--force]
[--force-version-override] [--all]
[--templatekernel=kernel]
[--directive='cli-directive=cli-value']
[--config=kernel-.config-location]
[--archive=tarball-location]
[--kernelsourcedir=source-location] [--no-prepare-kernel]
[--no-initrd]
[--binaries-only] [--source-only] [-r release (SuSE)]
[--verbose]
[--size] [--spec=specfile] [--media=floppy|iso|tar]
[--legacy-postinst=0|1]
[--no-depmod] [-j number] [--version]
Error! No action was specified.
You were also correct with lsmod | grep evdi running correctly but
returning nothing...
Not going to lie, my injury entailed a cracked rib, and a blow to the head,
so if you may kindly run me through the steps that are required to get
latest DisplayLink, evdi, then exchange the evdi in once more, I'd be
extremely grateful, and also very happy to test...
Thanks for all the help so far... (some things, like my injury, are a
little wakeup call to be kind)
…On Mon, 19 Oct 2020 at 18:40, Ben Greiner ***@***.***> wrote:
@robotard <https://github.com/robotard> In reply to your logs in #228
(comment)
<#228 (comment)>
machine_info.txt
EVDI kernel module version: None
What is the output of sudo dkms list? I guess lsmod | grep evdi is empty?
Likely, you did not compile the kernel module. Or rather DKMS did not do
it. Did you check the output during the installer for relevant information?
Did you finally consult
https://support.displaylink.com/knowledgebase/topics/103927-troubleshooting-ubuntu
and also
https://github.com/AdnanHodzic/displaylink-debian/blob/master/post-install-guide.md
?
And your dmesg.txt is empty, probably because you didn't run with enough
privileges.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#225 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB6C4OWHXVUY5M2LZ4HV23SLR2XTANCNFSM4SOANJSA>
.
|
Sorry to hear that. Please focus on your recovery rather than on a silly experimental software problem on the internet.
You maybe did that in your mail client, but they do not appear on the Github page and the attachment is not sent to anybody. Yet Again. But it will be useless anyway until you resolve the already identified issues.
Again, please check the Github issue page directly and stop replying by e-mail. I had noticed my mistake and corrected my comment immediately after I posted it. You likely did not get that by mail notification. The correct command is
So the install or module load was not successful.
Please read the comments in this thread directly on the Github page. Some posts were updated and should contain what you need to get started. For everything else, please refer to the linked forums. The Github issue page is not the right place for this. The patch has been tested by enough people and has been merged. We are just waiting on the release by the Displaylink guys. |
sudo dkms status Pulled all as described above, and replying to you directly from GitHub.... FWIW, I had to Also, I'm not sure I follow what you mean regarding the other issues (227 + 228)? Am I missing the fleetingly obvious? Seemed to build into DKMS ok... ? DisplayLink Un-Inst.txt |
@robotard Could you please move your support questions to the support forum? People are following this issue to stay up to date with the status of this problem. |
This looks much better now. There is no proof, that you patched the evdi module, but if it is the case, then you can seek help with these logs on the mentioned forums. You can also post a bugreport on https://bugs.launchpad.net/ubuntu/ Please don't use this issue page here. Your problems are not directly connected with Kernel 5.9 |
Thanks Ben, but all was well and good with 5.8?
It’s only since 5.9 I’ve had issues, and thus applied the patches that you guys are providing. Unfortunately do not seem to have fixed evdi since it appears to be loading now and on 5.9.
I’m more than happy to keep testing and offer you relevant logs, but this does seem to revolve around the kernel change directly.
Thanks,
R
|
OK, so I've just pushed new branch |
OK, with all of this i will close the issue. Thanks all for your involvement and comments :) |
It took me a couple hours to understand how to apply the latest changes to DisplayLink for Ubuntu.
This has also been reported here. |
Initially please make sure the problem hasn't been already addressed:
(https://www.displaylink.com/downloads/ubuntu)
(https://github.com/DisplayLink/evdi/releases)
on DisplayLink's website?
(https://support.displaylink.com/knowledgebase/topics/103927-troubleshooting-ubuntu)
(if it is rather connected to DisplayLinkManager please take a look at support
https://support.displaylink.com or forum https://www.displaylink.org/forum/)
Some information for baseline would help a lot:
Please provide good title for the issue and description.
If you can give us logs they will be welcome but please don't paste long listings
as they will make it hard to read the thread, instead you can use other services
for sharing raw text like pastebin or gist.
Also anything that may help to understand the problem will be appreciated
(configuration files, screenshots, photos, video capturing the problem).
Thanks!
The text was updated successfully, but these errors were encountered: