Allow standalone system simulation component #155
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosesyrett
changed the title
rosesyrett
changed the title
This involves changing the SystemSimulation input parameters, and making it so that the slave scheduler runs an 'initial' tick in the same way as master.
abbiemery
force-pushed
the
standalone-system-sim
branch
from
c178409
to
d6cd04f
Compare
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 94.69% 94.35% -0.35%
==========================================
Files 44 44
Lines 1264 1276 +12
==========================================
+ Hits 1197 1204 +7
- Misses 67 72 +5
|
Comment on lines
+1
to
+11
| - tickit.core.components.system_simulation.SystemSimulation: | ||
| name: internal_tickit | ||
| inputs: {} | ||
| components: | ||
| - examples.devices.counter.Counter: | ||
| name: counter | ||
| inputs: {} | ||
| - tickit.devices.sink.Sink: | ||
| name: counter_sink | ||
| inputs: | ||
| input: counter:value |
There was a problem hiding this comment.
Suggested change
| - tickit.core.components.system_simulation.SystemSimulation: | |
| name: internal_tickit | |
| inputs: {} | |
| components: | |
| - examples.devices.counter.Counter: | |
| name: counter | |
| inputs: {} | |
| - tickit.devices.sink.Sink: | |
| name: counter_sink | |
| inputs: | |
| input: counter:value | |
| - type: tickit.core.components.system_simulation.SystemSimulation | |
| name: internal_tickit | |
| inputs: {} | |
| components: | |
| - type: examples.devices.counter.Counter | |
| name: counter | |
| inputs: {} | |
| - type: tickit.devices.sink.Sink | |
| name: counter_sink | |
| inputs: | |
| input: | |
| component: counter | |
| port: value |
Comment on lines
+1
to
+12
| - tickit.core.components.system_simulation.SystemSimulation: | ||
| name: internal_tickit | ||
| inputs: {} | ||
| components: | ||
| - tickit.devices.source.Source: | ||
| name: internal_source | ||
| inputs: {} | ||
| value: 42 | ||
| - tickit.devices.sink.Sink: | ||
| name: internal_sink | ||
| inputs: | ||
| input: internal_source:value |
There was a problem hiding this comment.
Suggested change
| - tickit.core.components.system_simulation.SystemSimulation: | |
| name: internal_tickit | |
| inputs: {} | |
| components: | |
| - tickit.devices.source.Source: | |
| name: internal_source | |
| inputs: {} | |
| value: 42 | |
| - tickit.devices.sink.Sink: | |
| name: internal_sink | |
| inputs: | |
| input: internal_source:value | |
| - type: tickit.core.components.system_simulation.SystemSimulation | |
| name: internal_tickit | |
| inputs: {} | |
| components: | |
| - type: tickit.devices.source.Source | |
| name: internal_source | |
| inputs: {} | |
| value: 42 | |
| - type: tickit.devices.sink.Sink | |
| name: internal_sink | |
| inputs: | |
| input: | |
| component: internal_source | |
| port: value |
Comment on lines
+1
to
+8
| - tickit.devices.source.Source: | ||
| name: internal_source | ||
| inputs: {} | ||
| value: 42 | ||
| - tickit.devices.sink.Sink: | ||
| name: internal_sink | ||
| inputs: | ||
| input: internal_source:value |
There was a problem hiding this comment.
Suggested change
| - tickit.devices.source.Source: | |
| name: internal_source | |
| inputs: {} | |
| value: 42 | |
| - tickit.devices.sink.Sink: | |
| name: internal_sink | |
| inputs: | |
| input: internal_source:value | |
| - type: tickit.devices.source.Source | |
| name: internal_source | |
| inputs: {} | |
| value: 42 | |
| - type: tickit.devices.sink.Sink | |
| name: internal_sink | |
| inputs: | |
| input: | |
| component: internal_source | |
| port: value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves changing the SystemSimulation input parameters, and making it so that the slave scheduler runs an 'initial' tick in the same way as master.
Relates to #149