Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epics, Cothread and other changes #94

Merged
merged 18 commits into from
Jan 21, 2019

Conversation

T-Nicholls
Copy link
Collaborator

@T-Nicholls T-Nicholls commented Sep 28, 2018

No description provided.

@coveralls
Copy link

coveralls commented Sep 28, 2018

Coverage Status

Coverage increased (+0.4%) to 99.845% when pulling 9efb23f on T-Nicholls:epicsCothread into 1965494 on dls-controls:master.

pytac/cothread_cs.py Show resolved Hide resolved
pytac/cothread_cs.py Outdated Show resolved Hide resolved
pytac/cothread_cs.py Outdated Show resolved Hide resolved
pytac/cothread_cs.py Outdated Show resolved Hide resolved
@T-Nicholls
Copy link
Collaborator Author

Now we've added the ability to convert ControlSystemExceptions into prints at the lowest level, I think it would be nice to bring it all the way up as an optional argument. i.e. lattice.get_element_values('BPM', 'x', pytac.RB, throw=False.

@willrogers
Copy link
Collaborator

I have made a few changes and pushed them to https://github.com/dls-controls/pytac/tree/epicsCothread

They are not huge changes:

  • use logging instead of print
  • make sure that if a failure is not thrown, there is a way of finding out what failed

Have a look through and see what you think.

@T-Nicholls
Copy link
Collaborator Author

I have incorporated your improvements, written tests for all of cothread_cs, and made some miscellaneous changes to pytac that I had compiled.
I am happy with this, and it is ready to merge as far as I am concerned.

@willrogers willrogers merged commit 48a2522 into DiamondLightSource:master Jan 21, 2019
@T-Nicholls T-Nicholls deleted the epicsCothread branch February 25, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants